Fully migrate all scrapers to use your paginator #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few minor things in the paginator itself, then went through every scraper currently using an ArcGIS API call and migrated it over.
We need to change
ARCGIS_PAGINATION_DEPLOY_DATEto whatever day we deploy this to production to not generate cache misses. I believe once we migrate toli, this can all go away as the cache file name is no longer based on URL.I largely left scrapers alone except for this change, unless I found minor problems, i.e. fixed a thing in Florida and added a couple of Latvian city ISO codes that were missing.
As I reviewed the scrapers, I also added
// TODO: Should we really be setting these to zero?to any place I saw where we were doing parsing choices that we're discussing in #807I manually ran short timeseries for each scraper and checked by eye that the data did not show any dramatic changes, so I think this is all in working order.