-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release - v1.2.0 #182
Release - v1.2.0 #182
Conversation
Add test for providing a stream as an input
require() of ES Module /app/node_modules/megajs/node_modules/node-fetch/src/index.js from /app/node_modules/megajs/dist/main.node-cjs.js not supported. In latest version, I'd use example code |
I was kinda expecting that, that's why I ran the tests, I just didn't expected that the tests would not detect that. Please, send a pull request fixing it or wait until it bothers it me so much that I fix that myself. Which can take a lot of time since I'm delayed for work at the moment and I don't even know how I could find time to answer this comment... 😑 |
Other option, I forgot to comment, is downgrading node-fetch back to the v2 branch which still support require(). That's why node-fetch was in v2. |
alright thanks |
Ok, I just need to update documentation now. |
Release v1.2.0
Changelog
Minor Changes
Find and fetch (@qgustavor)
Implement find, search and navigate functions, and fix fetch related issues.
Patch Changes
Add test for providing a stream as an input (@qgustavor)
No, that's not because of the guy who doesn't read things, that's because I noticed there was not a test for that.