Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - v1.2.0 #182

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Release - v1.2.0 #182

merged 5 commits into from
Apr 18, 2024

Conversation

qgustavor
Copy link
Owner

@qgustavor qgustavor commented Mar 25, 2024

Release v1.2.0

Changelog

Minor Changes

Find and fetch (@qgustavor)

Implement find, search and navigate functions, and fix fetch related issues.

Patch Changes

Add test for providing a stream as an input (@qgustavor)

No, that's not because of the guy who doesn't read things, that's because I noticed there was not a test for that.

@AliAryanTech
Copy link

require() of ES Module /app/node_modules/megajs/node_modules/node-fetch/src/index.js from /app/node_modules/megajs/dist/main.node-cjs.js not supported.
Instead change the require of index.js in /app/node_modules/megajs/dist/main.node-cjs.js to a dynamic import() which is available in all CommonJS modules.

In latest version, I'd use example code

@qgustavor
Copy link
Owner Author

I was kinda expecting that, that's why I ran the tests, I just didn't expected that the tests would not detect that. Please, send a pull request fixing it or wait until it bothers it me so much that I fix that myself. Which can take a lot of time since I'm delayed for work at the moment and I don't even know how I could find time to answer this comment... 😑

@qgustavor
Copy link
Owner Author

Other option, I forgot to comment, is downgrading node-fetch back to the v2 branch which still support require(). That's why node-fetch was in v2.

@AliAryanTech
Copy link

Other option, I forgot to comment, is downgrading node-fetch back to the v2 branch which still support require(). That's why node-fetch was in v2.

alright thanks

@qgustavor qgustavor changed the title Release - v1.1.9 Release - v1.2.0 Apr 18, 2024
@qgustavor qgustavor merged commit 1d74498 into main Apr 18, 2024
8 checks passed
@qgustavor
Copy link
Owner Author

Ok, I just need to update documentation now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants