Environment variable name bug fix and documentation clarification #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1: support environment variable names that contain commas
From The Open Group specification:
TL;DR Commas are valid.
Commit 2: make it clearer that the name generation uses UPPER_SNAKE_CASE
The documentation (and the code/tests) misled me into thinking that the name generation used Sentence_Snake_Case because it includes examples such as
HostName
→Host_Name
andMyURL
→My_URL
. Even though the next bullet point says the name will be transformed to upper case, I think it is clearer to communicate that in the examples themselves.