Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable name bug fix and documentation clarification #2

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

fumoboy007
Copy link

Commit 1: support environment variable names that contain commas

From The Open Group specification:

These strings have the form name=value; names shall not contain the character ’='. For values to be portable across systems conforming to POSIX.1-2017, the value shall be composed of characters from the portable character set (except NUL and as indicated below).

TL;DR Commas are valid.

Commit 2: make it clearer that the name generation uses UPPER_SNAKE_CASE

The documentation (and the code/tests) misled me into thinking that the name generation used Sentence_Snake_Case because it includes examples such as HostNameHost_Name and MyURLMy_URL. Even though the next bullet point says the name will be transformed to upper case, I think it is clearer to communicate that in the examples themselves.

@qiangxue
Copy link
Owner

Great job! Thank you for your contribution!

@fumoboy007
Copy link
Author

Thanks for merging and thanks for the great library. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants