Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure on GPU for parallel lbfgs #297

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Fix test failure on GPU for parallel lbfgs #297

merged 1 commit into from
Dec 15, 2020

Conversation

scarrazza
Copy link
Member

Fixes test_vqe crash on GPU when running the parallel l-bfgs-b.

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #297 (9eeaf7f) into master (568bb2d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #297   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines        10583     10583           
=========================================
  Hits         10583     10583           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/tests/test_vqe.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 568bb2d...9eeaf7f. Read the comment docs.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't want to skip this we can also use with pytest.raises(RuntimeError), but either approach should be fine.

@scarrazza scarrazza merged commit 2a5fbe8 into master Dec 15, 2020
@scarrazza scarrazza deleted the fixgpu branch February 6, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants