Make DistributedState custom operator free #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 68 73 +5
Lines 11516 11963 +447
==========================================
+ Hits 11516 11963 +447
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Perfect thanks! |
scarrazza
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #320 by:
K.opin theDistributedStateby defining thetranspose_stateas a seperate backend method implemented using tf primitives whenbackend != "custom".DistributedStatetests in a different files which is skipped when the custom backend is not available as this state is not useful without theDistributedCircuitand this is only available for the custom backend.Note that this does not implement the
DistributedCircuitfor the einsum backends, but this should be not hard to do if we need it.Everything seems to work locally but let's see if the CI also passes.