-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiqubit GPU ops not called by JitCustomBackend #41
Conversation
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 983 978 -5
=========================================
- Hits 983 978 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I also made some changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding this! Both the fix and the readability changes look good to me.
I just hope that the previous fallback to CPU did not have any effect to the tests/benchmarks we were doing (thinking that we run on GPU but actually use CPU), although at least for the benchmarks I believe we would notice the difference from the results, particularly for high qibut numbers. Now it works in my machine and I can confirm that the multi-qubit GPU kernel is called during testing.
@mlazzarin thanks for these updates and fixes, looks good to me. |
@stavros11 I think the benchmarks of PR #23 and PR #37 are fine, because the fallback was removed in commit 58e1dfe and re-introduced only in commit 3183df2, and the benchmarks were performed in the middle of the two commits. We may need to re-run the tests with the different configurations, though, but I usually do it every time a create a new environment, so it should be fine. |
It looks like we forgot to update the call to the multiqubit GPU kernels in
JitCustomBackend
after we moved the latter from qibo to qibojit.