Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #450

Merged
merged 4 commits into from
May 26, 2023
Merged

fix #450

merged 4 commits into from
May 26, 2023

Conversation

Jacfomg
Copy link
Contributor

@Jacfomg Jacfomg commented May 25, 2023

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@Jacfomg Jacfomg closed this May 25, 2023
@Jacfomg Jacfomg deleted the results branch May 25, 2023 14:05
@Jacfomg Jacfomg restored the results branch May 25, 2023 14:05
@Jacfomg Jacfomg reopened this May 25, 2023
@Jacfomg Jacfomg added the run-on-tii1q_b1 Execute workflow on qpu label May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.02 🎉

Comparison is base (4c9ef91) 58.92% compared to head (7a9e65c) 58.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   58.92%   58.94%   +0.02%     
==========================================
  Files          39       39              
  Lines        5753     5756       +3     
==========================================
+ Hits         3390     3393       +3     
  Misses       2363     2363              
Flag Coverage Δ
unittests 58.94% <33.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibolab/instruments/rfsoc.py 46.26% <0.00%> (ø)
src/qibolab/result.py 91.54% <100.00%> (+0.37%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

alecandido
alecandido previously approved these changes May 25, 2023
@alecandido alecandido dismissed their stale review May 25, 2023 14:14

Broken on QPU

@Jacfomg Jacfomg added run-on-tii1q_b1 Execute workflow on qpu and removed run-on-tii1q_b1 Execute workflow on qpu labels May 25, 2023
@alecandido alecandido removed the run-on-tii1q_b1 Execute workflow on qpu label May 25, 2023
@Jacfomg
Copy link
Contributor Author

Jacfomg commented May 25, 2023

@rodolfocarobene some of the rfsoc failed could you take a look and tell me if you see something odd ?

@alecandido
Copy link
Member

This is decreasing the number of failing tests, so we can leave the rest up to a further PR.

@rodolfocarobene rodolfocarobene added run-on-tii1q_b1 Execute workflow on qpu and removed run-on-tii1q_b1 Execute workflow on qpu labels May 25, 2023
@rodolfocarobene
Copy link
Contributor

@rodolfocarobene some of the rfsoc failed could you take a look and tell me if you see something odd ?

I have now fixed them, the two still failing are related to attenuation and bias that the 4x2 does not support. Even though they should not fail, I agree that they are not fundamental and can be fixed elsewhere

@Jacfomg
Copy link
Contributor Author

Jacfomg commented May 25, 2023

thanks!

@rodolfocarobene some of the rfsoc failed could you take a look and tell me if you see something odd ?

I have now fixed them, the two still failing are related to attenuation and bias that the 4x2 does not support. Even though they should not fail, I agree that they are not fundamental and can be fixed elsewhere

src/qibolab/instruments/rfsoc.py Outdated Show resolved Hide resolved
tests/test_instruments_rfsoc.py Outdated Show resolved Hide resolved
@scarrazza scarrazza added this to the Qibolab 0.0.4 milestone May 26, 2023
@stavros11 stavros11 added the run-on-tii1q_b1 Execute workflow on qpu label May 26, 2023
@stavros11 stavros11 merged commit 8bb2819 into main May 26, 2023
@stavros11 stavros11 deleted the results branch May 26, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-on-tii1q_b1 Execute workflow on qpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants