-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #450
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
==========================================
+ Coverage 58.92% 58.94% +0.02%
==========================================
Files 39 39
Lines 5753 5756 +3
==========================================
+ Hits 3390 3393 +3
Misses 2363 2363
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@rodolfocarobene some of the rfsoc failed could you take a look and tell me if you see something odd ? |
This is decreasing the number of failing tests, so we can leave the rest up to a further PR. |
I have now fixed them, the two still failing are related to attenuation and bias that the 4x2 does not support. Even though they should not fail, I agree that they are not fundamental and can be fixed elsewhere |
thanks!
|
Checklist: