Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flushed out mobile friendly fork #1248

Closed
wants to merge 78 commits into from
Closed

Flushed out mobile friendly fork #1248

wants to merge 78 commits into from

Conversation

Ynng
Copy link
Contributor

@Ynng Ynng commented Jan 18, 2022

Flushed out all UI elements for mobile use, changed just about everything.
Most of the diff is just merging master into mobile.

There is still some room for improvement, but this is pretty usable already, hence the PR.

Future:

  • Support lyrics
  • Create CoverList component to display albums in lists instead of grid
  • Cleanup UI by moving items into hamburger menus

memorydream and others added 30 commits October 22, 2021 16:51
* fix: 在windows和linux中,当启动第二个窗口时,呼出已经启动的窗口

* prettier code

* change
* fix: correct zh-tw flag emoji

* Update settings.vue

Co-authored-by: qier222 <qier222@outlook.com>
* fix: goToList bug

* lyrics page title go to fix

* change
* issues qier222#1019 的迫真修复

* 修复 issues qier222#1019

* 修复 issues qier222#1019

* 改回 pickedLyric() 逻辑
* issues qier222#1019 的迫真修复

* 修复 issues qier222#1019

* 修复 issues qier222#1019

* 改回 pickedLyric() 逻辑

* 更进一步的避免取词卡死问题

* 更新网易云 api 到 4.2.0

* Update README.md

* Revert "Update README.md"

This reverts commit b862ef7.
Localize translations
本地化翻譯
* refactor: use @unblockneteasemusic/server

we also use ipcMain.handle for unblock-music.

* refactor(utils/nativeAlert): remove the deprecated "remote"

* refactor(ipcMain): use our default sources

* style(config/vue): prettier

* feat(README): update for new UNM
* issues qier222#1019 的迫真修复

* 修复 issues qier222#1019

* 修复 issues qier222#1019

* 改回 pickedLyric() 逻辑

* 更进一步的避免取词卡死问题

* 更新网易云 api 到 4.2.0

* Update README.md

* Revert "Update README.md"

This reverts commit b862ef7.

* Update lyrics.vue
* issues qier222#1019 的迫真修复

* 修复 issues qier222#1019

* 修复 issues qier222#1019

* 改回 pickedLyric() 逻辑

* 更进一步的避免取词卡死问题

* 更新网易云 api 到 4.2.0

* Update README.md

* Revert "Update README.md"

This reverts commit b862ef7.

* Update lyrics.vue

* 过滤歌词
* feat(ipcMain/unm): allow passing customized source

* feat(utils/Player): pass settings.unmSource

According to c280221,
we can let users customize their desired source now.

* feat(views/settings): allow configuring sources

We haven't supported specifying the environment variable in YPM yet.
* refactor(views/library): 修改取词逻辑

* refactor(views/library): clean up long-winded code

Co-authored-by: 是虹川飴 <r0akg9yxh@relay.firefox.com>
Closed: qier222#1133
Fixed: qier222#1019 qier222#1127 qier222#1067 qier222#1064 qier222#1058 qier222#1022
* fix(views/library): better lyric-picking logic

* feat(views/library): filter out lines with "作詞" and "作曲" included
Seems like Electron 13.6 breaks the Windows 7 support.
We degrade Electron's version to what 0.4.2 uses.

Related: qier222#1179
@vercel
Copy link

vercel bot commented Jan 19, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/qier222/yesplaymusic/5su6MAcL3kmQBakvMpfcodRVikfz
✅ Preview: https://yesplaymusic-git-fork-ynng-master-qier222.vercel.app

Ynng and others added 21 commits January 22, 2022 20:39
* fix: docker build failed qier222#1258

* refactor(docker): maximum the usage of cache

* fix(docker): "RUN" repeats two times

Fix qier222#1258

Co-authored-by: pan93412 <pan93412@gmail.com>
Seems like no any API breaking changes in icon-gen v3.
Besides, we can throw phantomjs away.

Fix qier222#1265
Fix qier222#1260
also:
  - docs: tells user to clone repo recursively
  - feat(ci): clone recursively
  - feat(ncmapi): backport my change
    Binaryify/NeteaseCloudMusicApi#1453
  - refactor: rewrite startNeteaseMusicApi()
* refactor(utils/lyrics): support multi-timestamp lyrics

Fully rewrited and improved the performance.

* refactor(utils/lyrics): remove useless .map

* fix(utils/lyrics): enhance the extraction logic
* fix(utils/lyrics): [min:sec] timestamp lyrics parse

* refactor(utils/lyrics): simplify time expression

* style(utils/lyrics): remove duplicate space

Co-authored-by: pan93412 <pan93412@gmail.com>
* refactor(ncmapi): use upstream version

FIXME: After qier222#1457 released,
switch to the NPM version.

* fix(docker): install NeteaseCloudMusicApi early

* fix: remove useless submodule entry

* fix(ncmapi): update to 4.5.2
* feat: mpris support

* fix: 修复网页版无法播放

* fix: 修复在 Player.js 里 ipcRenderer 为空时引发的错误

* docs: update README

* docs: update README

Co-authored-by: memorydream <34763046+memorydream@users.noreply.github.com>
@qier222
Copy link
Owner

qier222 commented May 11, 2022

预计2.0将会适配移动端(可能)

@qier222 qier222 closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.