Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite failure #55

Closed
tillea opened this issue Jan 25, 2023 · 2 comments
Closed

Test suite failure #55

tillea opened this issue Jan 25, 2023 · 2 comments

Comments

@tillea
Copy link

tillea commented Jan 25, 2023

Bug Description
FAILED q2_metadata/tests/test_tabulate.py::TestUsageExamples::test_examples

Steps to reproduce the behavior
I wanted to upgrade the Debian package of q2-metadata. You can find the full build log in the Debian development Git. It says:

_______________________ TestUsageExamples.test_examples ________________________
format_str = 'QualityFilterStatsDirFmt'
    def parse_format(format_str):
        if format_str is None:
            return None

        pm = qiime2.sdk.PluginManager()
        try:
>           format_record = pm.formats[format_str]
E           KeyError: 'QualityFilterStatsDirFmt'
/usr/lib/python3/dist-packages/qiime2/sdk/util.py:90: KeyError
During handling of the above exception, another exception occurred:
self = <q2_metadata.tests.test_tabulate.TestUsageExamples testMethod=test_examples>
    def test_examples(self):
>       self.execute_examples()
q2_metadata/tests/test_tabulate.py:108:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/usr/lib/python3/dist-packages/qiime2/plugin/testing.py:263: in execute_examples
    example_f(use)
q2_metadata/_examples.py:22: in tabulate_example
    stats = use.init_artifact_from_url('demux_stats', stats_url)
/usr/lib/python3/dist-packages/qiime2/sdk/usage.py:990: in init_artifact_from_url
    return self.init_artifact(name, factory)
/usr/lib/python3/dist-packages/qiime2/sdk/usage.py:1607: in init_artifact
    variable.execute()
/usr/lib/python3/dist-packages/qiime2/sdk/usage.py:581: in execute
    self.value = self.factory()
/usr/lib/python3/dist-packages/qiime2/sdk/usage.py:981: in factory
    result = qiime2.Artifact.load(f.name)
/usr/lib/python3/dist-packages/qiime2/sdk/result.py:79: in load
    archiver = archive.Archiver.load(filepath)
/usr/lib/python3/dist-packages/qiime2/core/archive/archiver.py:372: in load
    ref = cls(data_path, process_alias, Format(rec), cache)
/usr/lib/python3/dist-packages/qiime2/core/archive/format/v1.py:29: in __init__
    super().__init__(archive_record)
/usr/lib/python3/dist-packages/qiime2/core/archive/format/v0.py:73: in __init__
    self.format = sdk.parse_format(format)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
format_str = 'QualityFilterStatsDirFmt'
    def parse_format(format_str):
        if format_str is None:
            return None

        pm = qiime2.sdk.PluginManager()
        try:
            format_record = pm.formats[format_str]
        except KeyError:
>           raise TypeError("No format: %s" % format_str)
E           TypeError: No format: QualityFilterStatsDirFmt
/usr/lib/python3/dist-packages/qiime2/sdk/util.py:92: TypeError
---------- coverage: platform linux, python 3.11.1-final-0 -----------

Expected behavior
Just passing the full test suite you are providing.

Computation Environment

  • OS: Debian (unstable)
  • QIIME 2 Release: 2022.11.1

Kind regards, Andreas.

@ebolyen
Copy link
Member

ebolyen commented Jan 25, 2023

Hey @tillea,

That lines up with a failure we recently experienced when we added a usage example in #49

It created a dependency on q2-quality-filter which defines that missing format (7a15d2e) which I expect is not part of your dependency system.

We've since dropped those examples as it wasn't really a goal to induce that dependency in the first place: #54

So for the current release, updating the deps in your build system ought to get that working, and then the next release (2023.2) will go back to the original set of dependencies.

@ebolyen
Copy link
Member

ebolyen commented Jan 25, 2023

Closing for now, but let me know if I misunderstood the situation :)

@ebolyen ebolyen closed this as completed Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants