fix #1913 #2056
Merged
fix #1913 #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
antgonza
commented
Jan 21, 2017
•
antgonza
commented
- Fixed field with new line breaks preprocessing #1913 + added test
- Reduced the loops over the headers and full files
josenavas
suggested changes
Jan 23, 2017
| @@ -132,12 +116,30 @@ def load_template_to_dataframe(fn, strip_whitespace=True, index='sample_name'): | |||
| holdfile.insert(0, "%s\n" % '\t'.join(headers)) | |||
| # The QIIME parser fixes the index and removes the # | |||
| index = 'SampleID' | |||
| else: | |||
There was a problem hiding this comment.
Any reason why these checks are done only if the file is not a mapping file? Note that users can upload a QIIME mapping file instead of sample + prep information, so I think it is better if these checks are always executed (as they're before).
mortonjt
approved these changes
Jan 23, 2017
josenavas
approved these changes
Jan 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.