Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QHC-300] Add thresholded results to qblox #718

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

GuillermoAbadLopez
Copy link
Contributor

No description provided.

@GuillermoAbadLopez GuillermoAbadLopez changed the title Add thresholded results to qblox [QHC-300] Add thresholded results to qblox Apr 18, 2024
Copy link

linear bot commented Apr 18, 2024

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (74bbb8b) to head (0f4d95c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #718   +/-   ##
=======================================
  Coverage   96.18%   96.19%           
=======================================
  Files         275      275           
  Lines        9076     9084    +8     
=======================================
+ Hits         8730     8738    +8     
  Misses        346      346           
Flag Coverage Δ
unittests 96.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jjmartinezQT jjmartinezQT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, fix codecov please and then ready to merge.

Copy link
Contributor

@IsaacLA12 IsaacLA12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🪨

@GuillermoAbadLopez GuillermoAbadLopez merged commit 4c51aff into main Apr 24, 2024
6 checks passed
@GuillermoAbadLopez GuillermoAbadLopez deleted the thresholded_qblox_measure_results branch April 24, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants