use npm instead of yarn #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
注：在 image 中保留 yarn，同时提供 npm 5.x。这里将创建 image 时 fec-builder 本身的依赖使用 npm 安装，项目的 |
doxiaodong
reviewed
Sep 22, 2017
| && npm install fs-extra \ | ||
| && sed -i -e s/graceful-fs/fs-extra/ -e s/fs\.rename/fs.move/ ./lib/utils/rename.js | ||
| # upgrade npm | ||
| RUN npm install -g npm@5.4.2 |
There was a problem hiding this comment.
这里直接用 node 8.0 以上的版本吧
我记得好像 8.0 以下的 装 npm5 可能会出现问题
There was a problem hiding this comment.
我这遇到过王克纯那边 node 8.x 跑 builder 有坑...
升 node 版本的影响面比较大。我本地是一直用的 node 6.x + npm 5.x，目前还没啥问题，毕竟 npm 只是拿来装依赖，我觉得这个风险小一点
| && sed -i -e s/graceful-fs/fs-extra/ -e s/fs\.rename/fs.move/ ./lib/utils/rename.js | ||
| # upgrade npm | ||
| RUN npm install -g npm@5.4.2 | ||
|
|
There was a problem hiding this comment.
这个为了速度的话，可以加上
RUN echo "deb http://mirrors.aliyun.com/debian stretch main\n\
deb http://mirrors.aliyun.com/debian stretch-updates main\n\
deb http://mirrors.aliyun.com/debian-security stretch/updates main" > /etc/apt/sources.list
There was a problem hiding this comment.
这个只是 build image 的时候执行，执行过一次以后就走 docker 的缓存了，暂时不用加
|
可以吧，我不用 image 里的，你那边合适就行 |
doxiaodong
approved these changes
Sep 22, 2017
|
@doxiaodong 嗯，暂时对 node 8.x 还没啥信心，等我信心够了再升...image 是用到 jenkins 构建里的，直接影响线上结果，我虚啊 |
|
哈，node 8 lts 就快来了，不要慌 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16 用 npm 替代 yarn