-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add merge command #91
Conversation
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 81.05% 81.32% +0.26%
==========================================
Files 33 34 +1
Lines 1742 1767 +25
==========================================
+ Hits 1412 1437 +25
Misses 209 209
Partials 121 121
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/assign @CarlJi |
Short: "Merge multiple coherent Go coverage files into a single file.", | ||
Long: `merge will merge multiple Go coverage files into a single coverage file. | ||
merge requires that the files are 'coherent', meaning that if they both contain references to the | ||
same paths, then the contents of those source files were identical for the binary that generated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
were
=> are
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
binary is generated some times ago, so it should be were.
actually i copy the 'long' content from https://github.com/kubernetes/test-infra/blob/master/gopherage/cmd/merge/merge.go. >_<
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CarlJi, lyyyuna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix #89
Most of logic is from:
https://github.com/kubernetes/test-infra/blob/master/gopherage/cmd/merge/merge.go