fallback handler #84
Merged
fallback handler #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 75.79% 75.79%
=======================================
Files 17 17
Lines 1128 1128
=======================================
Hits 855 855
Misses 242 242
Partials 31 31 ☔ View full report in Codecov by Sentry. |
cpunion
force-pushed
the
fallback-handler
branch
from
313f420
to
af72b9e
Compare
xushiwei
reviewed
Oct 3, 2023
http/fallback/fallback.go
Outdated
|
|
||
| // Fallback is a http.Handler that fallback to second handler if status code of | ||
| // first handler is in fallbackStatus | ||
| func Fallback(fallbackStatus []int, first http.Handler, second http.Handler) http.Handler { |
There was a problem hiding this comment.
maybe Fallback => New is better?
xushiwei
reviewed
Oct 3, 2023
http/fallback/fallback.go
Outdated
| } | ||
|
|
||
| type fallbackWriter struct { | ||
| open bool |
There was a problem hiding this comment.
bool field usually is defined at the end
cpunion
force-pushed
the
fallback-handler
branch
from
af72b9e
to
de1036c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.