Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up qirlib generator API to match current Python API #53

Closed
bamarsha opened this issue Feb 17, 2022 · 0 comments · Fixed by #147
Closed

Clean up qirlib generator API to match current Python API #53

bamarsha opened this issue Feb 17, 2022 · 0 comments · Fixed by #147
Labels
maintenance Code quality improvement or maintenance

Comments

@bamarsha
Copy link
Contributor

bamarsha commented Feb 17, 2022 •
edited
Loading

The qirlib generator API contains some older design choices that don't match the new pyqir-generator API (#32), and should be reconsidered:

  • Instructions use string identifiers for results and qubits, but the new Python API abstracts away the string. It would be simpler and cheaper to use numeric identifiers.
  • QuantumRegister represents a single qubit, but ClassicalRegister represents a sequence of results, which is asymmetric. The Python API treats them symmetrically.
@bamarsha bamarsha added the maintenance Code quality improvement or maintenance label Feb 17, 2022
@bamarsha bamarsha self-assigned this Feb 17, 2022
@bamarsha bamarsha mentioned this issue Feb 17, 2022
Merged
@bamarsha bamarsha removed their assignment Apr 14, 2022
@bamarsha bamarsha changed the title Clean up internal generator API to match incoming Python API Clean up internal generator API to match current Python API May 26, 2022
@bamarsha bamarsha changed the title Clean up internal generator API to match current Python API Clean up qirlib generator API to match current Python API Aug 8, 2022
@bamarsha bamarsha mentioned this issue Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Code quality improvement or maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dynamic allocation for qubits and results qir-alliance/pyqir
1 participant
@bamarsha