Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyQIR generator API redesign with classical if statement #43

Merged
merged 65 commits into from
Feb 17, 2022
Merged

PyQIR generator API redesign with classical if statement #43

merged 65 commits into from
Feb 17, 2022

Conversation

bamarsha
Copy link
Contributor

@bamarsha bamarsha commented Feb 3, 2022

Closes #32.

Sarah Marshall added 30 commits December 10, 2021 15:20
New declarative Python API based on Rust API
73bf912
Add Instruction::If to Rust API
ad37c39
Clean up names
841866d
Clean up
cc81614
Implement If instruction emission
c6bd462
Clean up emit_if
4946ad5
Use get_register
c1f2150
Add result module
55132e5
Add set_register_result
7320b5f
Add eval tests for "if"
08c7ab3
Merge branch 'main' into samarsha/if
284ff4c
Merge branch 'main' into samarsha/if
8590645
Add skeleton Rust pyclasses for new API
ca0c441
Implement instructions except if
5a5966a
Refactor adding instructions
78a4e3a
Implement if_result
82133f3
Pass through GIL token
71c3f9c
Panic if builder doesn't have 1 frame
0c3920b
Make one/zero callbacks optional
9cebed3
Update Python modules
d765dd5
Add docstrings
9f35943
Merge branch 'main' into samarsha/if
1f4bfed
Update examples
3b4c8a6
Update test_eval
3438c34
Use package namespace
cb6aabd
Update example imports
735ce6c
Merge branch 'main' into samarsha/if
0ed3d78
Implement SimpleModule::bitcode
88daa1b
Merge branch 'main' into samarsha/if
0c1c98f
Merge branch 'main' into samarsha/if
7404724
@idavis idavis requested a review from swernli February 14, 2022 20:33
swernli
swernli approved these changes Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but overall it all looks good!

pyqir-generator/pyqir/generator/__init__.py Show resolved Hide resolved
pyqir-generator/pyqir/generator/qis.pyi Show resolved Hide resolved
pyqir-generator/pyqir/generator/value.pyi Outdated Show resolved Hide resolved
pyqir-generator/src/python.rs Show resolved Hide resolved
pyqir-generator/src/qir/instructions.rs Outdated Show resolved Hide resolved
pyqir-jit/src/python.rs Outdated Show resolved Hide resolved
pyqir-parser/Cargo.toml Show resolved Hide resolved
pyqir-tests/tests/test_teleport.py Outdated Show resolved Hide resolved
pyqir-tests/tests/test_teleport.py Outdated Show resolved Hide resolved
cgranade
cgranade reviewed Feb 15, 2022
View reviewed changes
Copy link
Contributor

@cgranade cgranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving as comments only since it's the PR is still in draft, but had a few thoughts here and there. Really exciting to see this all come together! ♥

pyqir-generator/pyqir/__init__.py Show resolved Hide resolved
eng/psakefile.ps1 Show resolved Hide resolved
examples/jit/bernstein_vazirani.py Outdated Show resolved Hide resolved
pyqir-generator/pyqir/generator/__init__.py Show resolved Hide resolved
pyqir-generator/pyqir/generator/builder.pyi Show resolved Hide resolved
pyqir-generator/src/python.rs Show resolved Hide resolved
pyqir-generator/src/python.rs Show resolved Hide resolved
pyqir-generator/tests/test_api.py Show resolved Hide resolved
pyqir-jit/pyqir/jit/nonadaptivejit.py Outdated Show resolved Hide resolved
pyqir-jit/src/python.rs Outdated Show resolved Hide resolved
@cgranade cgranade mentioned this pull request Feb 15, 2022
Merged
@bamarsha bamarsha marked this pull request as ready for review February 16, 2022 02:03
@bamarsha bamarsha mentioned this pull request Feb 17, 2022
Closed
2 tasks
@bamarsha bamarsha enabled auto-merge (squash) February 17, 2022 20:58
@bamarsha bamarsha merged commit efcbf1b into main Feb 17, 2022
@bamarsha bamarsha deleted the samarsha/if branch February 17, 2022 21:05
@idavis idavis restored the samarsha/if branch February 17, 2022 21:16
@idavis idavis deleted the samarsha/if branch February 17, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swernli swernli swernli approved these changes

@cgranade cgranade cgranade left review comments

@idavis idavis idavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyQIR generator API redesign with classical if statement
4 participants
@bamarsha @cgranade @idavis @swernli