Allowing multiple LLVM versions to be used. #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idavis
force-pushed
the
iadavis/multiple-llvm-version
branch
from
fc552ba
to
3702251
Compare
idavis
force-pushed
the
iadavis/multiple-llvm-version
branch
2 times, most recently
from
876c5c1
to
2c66ef4
Compare
…o ordering issues. Stopping --user as user site-packages are not visible in virtualenv.
idavis
force-pushed
the
iadavis/multiple-llvm-version
branch
from
a8d2f18
to
682d7cd
Compare
|
This does not fully address #35, but makes the change very simple. |
|
Hey @idavis, thanks for this! I've tested building with Let me know there is any other specific surface area I can help test. |
|
Thanks @nilslice ! I think the issue is that pyo3 isn't marked as an optional dependency. I'll give that a try and push. |
|
@nilslice Can you please pull and try again? |
|
@idavis That was it indeed - fixed. |
swernli
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR set up the ability to compile against multiple versions of LLVM. Setting
PYQIR_LLVM_FEATURE_VERSIONto one of the following valuesllvm11-0,llvm12-0, andllvm13-0will change the LLVM version for all components.LLVM-IRdoesn't support LLVM 14, so 14 was not added to the build. The default value if the environment variable isn't set isllvm11-0.I have not added and build configurations for CI. The default LLVM version for
qirlibis not specified, but the build will fail if the features isn't set.This PR is based off of the work @nilslice did for #114.