Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating pyo3 and maturin to latest versions. #16

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Updating pyo3 and maturin to latest versions. #16

merged 2 commits into from
Dec 1, 2021

Conversation

idavis
Copy link
Collaborator

@idavis idavis commented Nov 30, 2021

  • The 0.15.x pyo3 is the last version to support Python 3.6 which is EOL Dec 2021

cgranade
cgranade approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@cgranade cgranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth adding the terms highlighted by the spell check CI job to cspell.json so as to cut down on false positive warnings.

@idavis idavis merged commit f8ad65c into main Dec 1, 2021
@idavis idavis deleted the iadavis/update-pyo3-maturin branch December 1, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bamarsha bamarsha bamarsha approved these changes

@cgranade cgranade cgranade approved these changes

@bettinaheim bettinaheim Awaiting requested review from bettinaheim

Assignees

@cgranade cgranade

@idavis idavis

@bamarsha bamarsha

@bettinaheim bettinaheim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idavis @cgranade @bamarsha @bettinaheim