Use new CodeGenModel trait for generation to allow extensibility #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was accidentally closed by GH when the PR was merged. |
allows extensibility to other structures that implement CodeGenModel that can be written out to QIR
|
|
|
Closing as this is not a change critical to my development and may not align well with more recent changes to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baased on #46, only the final few commits are new.
Other tools may wish to use the same code generation utilities but with a different "SemanticModel", this trait allows for that.
As there are accessors for all members
SemanticModelmembers are made private.Instruction code gen utilities are made public for reuse.
These changes are used here: to protoype QIR code generation from the tket JSON IR.