-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving features into experimental #58
Conversation
@troelsfr Could you please ensure that all APIs (and also doc comments, but I don't mind if these get gradually updated) follow American standard spelling? While that is not a reflection of who the tool is for, overall it is nicer and less surprising for users to have some consistency across all tools/packages that we maintain. |
Sure. I will pick this up on Monday.
…On Sat, 26 Feb 2022, 04:11 Bettina Heim, ***@***.***> wrote:
@troelsfr <https://github.com/troelsfr> Could you please ensure that all
APIs (and also doc comments, but I don't mind if these get gradually
updated) follow American standard spelling? While that is not a reflection
of who the tool is for, overall it is nicer and less surprising for users
to have some consistency across all out tools.
—
Reply to this email directly, view it on GitHub
<#58 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEMHDXQGH3D6WUWXIBZZBDU5BAGPANCNFSM5PD27RJQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, but one thing that took me a while to piece together is that experimental features effectively have two default settings: one default when experimental is not provided and one when it is. The help description of these parameters is a little confusing in that regard, because it describes some parameters as default true
and it makes it seem as if some experimental features are enabled by default for normal operation. Perhaps some additional text on the --experimental
parameter itself to clarify that any features that are marked EXPERIMENTAL
are disabled if the top level --experimental
param is not provided?
Yes, this is a good suggestion. I will make this change today. |
All experimental and non-experimental features are listed in the help section: