Update CI PSI4 install #1266
Merged
Update CI PSI4 install #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6738591181
💛 - Coveralls |
This was referenced Nov 3, 2023
ialsina
pushed a commit
to ialsina/qiskit-nature
that referenced
this pull request
Nov 17, 2023
* Update CI PSI4 install * Switch windows to conda-forge * Switch install as given by psicode.org * Comment openmp install for Mac to see * Comment openmp install for Mac to see * Remove platform if's as all same now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Nightly tests seem to sometimes be failing around PSI4 with Windows and Python 3.8. CI is using Windows 2019 (not latest) and an older 1.6 PSI4. Newer versions of PSI4 are out there which also now support 3.11 so it can be installed there now too. I think part of using WIndows-2019 was that we used to build Aer and that was done in that platform.
Anyway this does two things, first changes to
windows-latestinstead ofwindows-2019(presently latest is windows-2022) and it removes the PSI4 1.6 specific version install to install whatever is the stable release, as well as installing it across the board (i.e. remove platform/version restrictions)I will note the Windows and the default (Ubuntu) sections of the PSI4 install action now are the same, but I left them in separate blocks for now. I am unsure if the openmp updates are needed for Mac, but it seemed that could be done anyway so I left them. I want to see how this change fairs before thinking about possibly collapsing the blocks - though it does no harm to leave them as-is in case things need differentiating still (or in the future) - which is really why I did not already do this.
Update: In the end the openmp updates that were needed for the version Mac 3.8 was using is now not needed. The conda install info/syntax was taken from https://psicode.org/installs/v182/ where its the same for all platforms. This works fine and now 3.11 CI includes PSI4 (for all platforms) where it did not before. Currently its installing 1.8.2 across the board versus 1.7 for Ubuntu and 1.6 for Windows & Mac as things were. I simplified the PSI4 install action to remove the if/then based on platform since the contents ended up all the same.
Details and comments