Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync finish bug #825

Merged
merged 1 commit into from
Dec 12, 2019
Merged

fix: sync finish bug #825

merged 1 commit into from
Dec 12, 2019

Conversation

lc3091
Copy link
Contributor

@lc3091 lc3091 commented Dec 12, 2019

Proposed changes in this pull request

fix sync finish bug

Type

  • Bug fix: (Link to the issue #{issue No.})
  • Feature (Non-breaking change)
  • Feature (Breaking change)
  • Documentation Improvement

Checklist

Write a small comment explaining if its N/A (not applicable)

  • Read the CONTRIBUTION.
  • All the tests are passing after the introduction of new changes.
  • Added tests respective to the part of code I have written.
  • Added proper documentation where ever applicable.
  • Code has been written according to Golang-Style-Guide

Extra information

Any extra information related to this pull request.

@lc3091 lc3091 self-assigned this Dec 12, 2019
@lc3091 lc3091 added the ready-to-rebase-and-merge ready-to-rebase-and-merge label Dec 12, 2019
@lc3091 lc3091 added this to the v1.3.x milestone Dec 12, 2019
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #825 into release/v1.3.1 will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/v1.3.1     #825      +/-   ##
==================================================
+ Coverage           37.03%   37.06%   +0.03%     
==================================================
  Files                 241      241              
  Lines               33963    33953      -10     
==================================================
+ Hits                12577    12584       +7     
+ Misses              18709    18692      -17     
  Partials             2677     2677
Flag Coverage Δ
#unittests 37.06% <0%> (+0.03%) ⬆️
Impacted Files Coverage Δ
consensus/dpos/dpos_impl.go 7.23% <0%> (-0.04%) ⬇️
consensus/pov/pov_sync.go 31.02% <0%> (-0.52%) ⬇️
consensus/pov/pov_chain.go 42.82% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14844a6...a3fa245. Read the comment docs.

@gythialy gythialy merged commit 103735e into release/v1.3.1 Dec 12, 2019
@mergify mergify bot deleted the hotfix/sync-finish-bug branch December 12, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-rebase-and-merge ready-to-rebase-and-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants