Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pubkey distribution #851

Merged
merged 36 commits into from
Feb 10, 2020
Merged

feat: pubkey distribution #851

merged 36 commits into from
Feb 10, 2020

Conversation

lc3091
Copy link
Contributor

@lc3091 lc3091 commented Dec 27, 2019

Proposed changes in this pull request

1: add decentralized public key distribution system
2: add rpc over modules

Type

  • Bug fix: (Link to the issue #{issue No.})
  • Feature (Non-breaking change)
  • Feature (Breaking change)
  • Documentation Improvement

Checklist

Write a small comment explaining if its N/A (not applicable)

  • Read the CONTRIBUTION.
  • All the tests are passing after the introduction of new changes.
  • Added tests respective to the part of code I have written.
  • Added proper documentation where ever applicable.
  • Code has been written according to Golang-Style-Guide

Extra information

Any extra information related to this pull request.

@lc3091 lc3091 self-assigned this Dec 27, 2019
@lc3091 lc3091 added the ready-to-rebase-and-merge ready-to-rebase-and-merge label Dec 27, 2019
@codecov
Copy link

codecov bot commented Dec 27, 2019 •
edited
Loading

Codecov Report

Merging #851 into master will increase coverage by 2.92%.
The diff coverage is 20.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #851      +/-   ##
==========================================
+ Coverage   36.57%   39.49%   +2.92%     
==========================================
  Files         257      258       +1     
  Lines       37278    37152     -126     
==========================================
+ Hits        13634    14674    +1040     
+ Misses      20829    19578    -1251     
- Partials     2815     2900      +85
Flag Coverage Δ
#unittests 39.49% <20.42%> (+2.92%) ⬆️
Impacted Files Coverage Δ
common/types/address.go 63.11% <ø> (+2.48%) ⬆️
p2p/sync.go 4.34% <ø> (+0.01%) ⬆️
ledger/ledger.go 31.89% <ø> (ø) ⬆️
p2p/qlcService.go 61.64% <ø> (ø) ⬆️
consensus/dpos/active_transactions.go 67.88% <ø> (+48.62%) ⬆️
consensus/dpos/votes.go 90.9% <ø> (ø) ⬆️
vm/contract/abi/abi_public_key_distribution.go 55.18% <ø> (ø) ⬆️
consensus/dpos/online.go 74.07% <ø> (+57.77%) ⬆️
consensus/dpos/election.go 75.19% <ø> (+58.28%) ⬆️
rpc/api/debug.go 0% <0%> (ø) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f862936...f802f67. Read the comment docs.

gythialy
gythialy suggested changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@gythialy gythialy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe more UT for contracts

common/service.go Show resolved Hide resolved
common/util/hexutil/hexutil.go Outdated Show resolved Hide resolved
common/util/util.go Outdated Show resolved Hide resolved
rpc/rpc.go Outdated Show resolved Hide resolved
vm/vmstore/vm_store.go Outdated Show resolved Hide resolved
lc3091 and others added 14 commits January 2, 2020 09:42
@lc3091
fix: add test cases
d6ef922
@lc3091
fix: go vet
4afc5f4
@lc3091
fix: add gap publish block to uncheck stat
e1d3a41
@lc3091
fix: merge public key distribution contracts
7744fde 
Signed-off-by: lichao <chao.li@qlink.mobi>
@lc3091
fix: go test
a0cc4bf 
Signed-off-by: lichao <chao.li@qlink.mobi>
@lc3091
Merge branch 'master' into feature/pubkey-distribution
03e7bf8 
Signed-off-by: lichao <chao.li@qlink.mobi>
@lc3091
fix: pkd api update
e582a2d
@lc3091
fix: update dpki api name
f711e54 
Signed-off-by: lichao <chao.li@qlink.mobi>
@lc3091
fix: dpki optimization
0698d16 
Signed-off-by: lichao <chao.li@qlink.mobi>
feat: update oracle state on pov chain
61edd11
@lc3091
fix: DPKI contract refactor
446e0f9 
Signed-off-by: lichao <chao.li@qlink.mobi>
@lc3091
Merge branch 'feature/pubkey-distribution' of https://github.com/qlcc…
05850b4 
…hain/go-qlc into feature/pubkey-distribution

Signed-off-by: lichao <chao.li@qlink.mobi>
fix: update contract data in sync
0827a19
@lc3091
fix: sync optimize
f8b151d 
Signed-off-by: lichao <chao.li@qlink.mobi>
wenyuangui and others added 14 commits January 17, 2020 11:31
fix: no need process genesis block in pov
02c4c35
@lc3091
Merge branch 'feature/pubkey-distribution' of https://github.com/qlcc…
fddaa3e 
…hain/go-qlc into feature/pubkey-distribution
@lc3091
fix: sync optimize
4e49522 
Signed-off-by: lichao <chao.li@qlink.mobi>
feat: add independent statedb for each contract address
f859e34
fix: update pov global and contract state db
490281f
fix: need commit contract state to db
c6c68bc
fix: update publish & verify state in pov
761bb06
feat: add dpki reward
59cc095
@lc3091
Merge branch 'master' into feature/pubkey-distribution
f862936 
Signed-off-by: lichao <chao.li@qlink.mobi>
@lc3091
fix: optimize contract
9d87dfe 
Signed-off-by: lichao <chao.li@qlink.mobi>
feat: dpki reward rpcs and cmds
35041a1
@lc3091
feat: add consensus unit test
c0982f5 
Signed-off-by: lichao <chao.li@qlink.mobi>
@lc3091
feat: add consensus unit test cases
37da56a 
Signed-off-by: lichao <chao.li@qlink.mobi>
@lc3091
Merge branch 'feature/pubkey-distribution' of https://github.com/qlcc…
cb29012 
…hain/go-qlc into feature/pubkey-distribution

fix(#894)
Signed-off-by: lichao <chao.li@qlink.mobi>
@lc3091 lc3091 removed the ready-to-rebase-and-merge ready-to-rebase-and-merge label Feb 7, 2020
lc3091 and others added 2 commits February 7, 2020 19:52
@lc3091 lc3091 added the ready-to-rebase-and-merge ready-to-rebase-and-merge label Feb 10, 2020
gythialy
gythialy approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@gythialy gythialy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit b9acb1a into master Feb 10, 2020
@mergify mergify bot deleted the feature/pubkey-distribution branch February 10, 2020 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harlanasimov harlanasimov harlanasimov approved these changes

@gythialy gythialy gythialy approved these changes

@wenchaopeng wenchaopeng Awaiting requested review from wenchaopeng wenchaopeng is a code owner

@zengchen221 zengchen221 Awaiting requested review from zengchen221 zengchen221 is a code owner

Assignees

@lc3091 lc3091

Labels
ready-to-rebase-and-merge ready-to-rebase-and-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lc3091 @gythialy @harlanasimov