Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dpki unit test #919

Merged
merged 9 commits into from
Feb 20, 2020
Merged

feat: dpki unit test #919

merged 9 commits into from
Feb 20, 2020

Conversation

lc3091
Copy link
Contributor

@lc3091 lc3091 commented Feb 20, 2020

Proposed changes in this pull request

Explain the changes in this pull request in order to help the project maintainers understand the overall impact of it.

Please put an x against the checkboxes.

Type

  • Bug fix: (Link to the issue #{issue No.})
  • Feature (Non-breaking change)
  • Feature (Breaking change)
  • Documentation Improvement

Checklist

Write a small comment explaining if its N/A (not applicable)

  • Read the CONTRIBUTION.
  • All the tests are passing after the introduction of new changes.
  • Added tests respective to the part of code I have written.
  • Added proper documentation where ever applicable.
  • Code has been written according to Golang-Style-Guide

Extra information

Any extra information related to this pull request.

Signed-off-by: lichao <chao.li@qlink.mobi>
Signed-off-by: lichao <chao.li@qlink.mobi>
Signed-off-by: lichao <chao.li@qlink.mobi>
Signed-off-by: lichao <chao.li@qlink.mobi>
Signed-off-by: lichao <chao.li@qlink.mobi>
Signed-off-by: lichao <chao.li@qlink.mobi>
Signed-off-by: lichao <chao.li@qlink.mobi>
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #919 into master will increase coverage by 2.77%.
The diff coverage is 46.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
+ Coverage   41.01%   43.78%   +2.77%     
==========================================
  Files         258      266       +8     
  Lines       37476    42247    +4771     
==========================================
+ Hits        15369    18498    +3129     
- Misses      19138    20072     +934     
- Partials     2969     3677     +708
Flag Coverage Δ
#unittests 43.78% <46.92%> (+2.77%) ⬆️
Impacted Files Coverage Δ
common/types/address.go 63.11% <ø> (ø) ⬆️
vm/contract/contract.go 8.62% <ø> (+8.62%) ⬆️
vm/contract/abi/abi_settlement_gen.go 41.86% <ø> (ø)
ledger/relation/relation_impl.go 38.24% <ø> (ø) ⬆️
common/types/hash.go 28.05% <0%> (-1.05%) ⬇️
common/genesis.go 0% <0%> (ø) ⬆️
common/types/pov_algo.go 0% <0%> (ø) ⬆️
common/types/block_pov.go 0% <0%> (ø) ⬆️
vm/contract/public_key_distribution.go 42.08% <0%> (-0.17%) ⬇️
common/params_pov.go 0% <0%> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cafac7...62e64ab. Read the comment docs.

Signed-off-by: lichao <chao.li@qlink.mobi>
@lc3091 lc3091 added the ready-to-rebase-and-merge ready-to-rebase-and-merge label Feb 20, 2020
@mergify mergify bot merged commit ad5dfbc into master Feb 20, 2020
@mergify mergify bot deleted the feature/dpki-unit-test branch February 20, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-rebase-and-merge ready-to-rebase-and-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants