New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip changes #157

merged 10 commits into from Feb 1, 2019


None yet
4 participants
Copy link

hrigner commented Jan 30, 2019

  • Color the Primary/Perfect text.
  • Toggle tooltip on more-details click.
  • Break word on overflow to prevent long table and field names to overflow.

This comment has been minimized.

Copy link

netlify bot commented Jan 30, 2019

Deploy preview for catwalk-qlikcore ready!

Built with commit 6dbf6cb

@hrigner hrigner requested a review from sublibra Jan 30, 2019

Copy link

sublibra left a comment

Looking good!

I think the tooltip X and the open tooltip elipsis should have the same hoover effect as the other x and ellipsis (blue) .

But might not be part of this pull request and can be done in a follow up in the future

@hrigner hrigner requested a review from peol Feb 1, 2019


peol approved these changes Feb 1, 2019

Copy link

peol left a comment

LGTM, minor comment

Show resolved Hide resolved src/components/guide.jsx Outdated
Copy link

FredrikFolkesson left a comment


@@ -86,6 +91,10 @@ export default function Model({ app, appLayout }) {
} else if (field) {
// Open or close a field
// If synthetic, do nothing.

This comment has been minimized.


FredrikFolkesson Feb 1, 2019


Nice! That was not so pretty before :)

@hrigner hrigner merged commit ea593d1 into master Feb 1, 2019

3 of 4 checks passed

coverage/coveralls Coverage decreased (-0.06%) to 5.125%
ci/circleci: build Your tests passed on CircleCI!
cla/verification CLA OK
deploy/netlify Deploy preview ready!

@hrigner hrigner deleted the tooltip-changes branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment