Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Tooltip changes #157

Merged
merged 10 commits into from
Feb 1, 2019
Merged

Tooltip changes #157

merged 10 commits into from
Feb 1, 2019

Conversation

hrigner
Copy link

@hrigner hrigner commented Jan 30, 2019

  • Color the Primary/Perfect text.
  • Toggle tooltip on more-details click.
  • Break word on overflow to prevent long table and field names to overflow.

@netlify
Copy link

netlify bot commented Jan 30, 2019

Deploy preview for catwalk-qlikcore ready!

Built with commit 6dbf6cb

https://deploy-preview-157--catwalk-qlikcore.netlify.com

@hrigner hrigner requested a review from sublibra January 30, 2019 14:28
Copy link
Contributor

@sublibra sublibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

I think the tooltip X and the open tooltip elipsis should have the same hoover effect as the other x and ellipsis (blue) .

But might not be part of this pull request and can be done in a follow up in the future

@hrigner hrigner requested a review from peol February 1, 2019 08:55
Copy link
Contributor

@peol peol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment

src/components/guide.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@FredrikFolkesson FredrikFolkesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -86,6 +91,10 @@ export default function Model({ app, appLayout }) {
setQueryModel(newQueryModel);
} else if (field) {
// Open or close a field
// If synthetic, do nothing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That was not so pretty before :)

@hrigner hrigner merged commit ea593d1 into master Feb 1, 2019
@hrigner hrigner deleted the tooltip-changes branch February 1, 2019 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants