-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
hrigner
commented
Jan 30, 2019
- Color the Primary/Perfect text.
- Toggle tooltip on more-details click.
- Break word on overflow to prevent long table and field names to overflow.
Deploy preview for catwalk-qlikcore ready! Built with commit 6dbf6cb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
I think the tooltip X and the open tooltip elipsis should have the same hoover effect as the other x and ellipsis (blue) .
But might not be part of this pull request and can be done in a follow up in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -86,6 +91,10 @@ export default function Model({ app, appLayout }) { | |||
setQueryModel(newQueryModel); | |||
} else if (field) { | |||
// Open or close a field | |||
// If synthetic, do nothing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! That was not so pretty before :)