New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding styling to show differences between selected states #169

Merged
merged 3 commits into from Feb 7, 2019

Conversation

Projects
None yet
3 participants
@hrigner
Copy link
Member

hrigner commented Feb 4, 2019

Closes #168

@hrigner hrigner requested a review from peol Feb 4, 2019

@netlify

This comment has been minimized.

Copy link

netlify bot commented Feb 4, 2019

Deploy preview for catwalk-qlikcore ready!

Built with commit 120c0bc

https://deploy-preview-169--catwalk-qlikcore.netlify.com

@hrigner

This comment has been minimized.

Copy link
Member Author

hrigner commented Feb 4, 2019

I don't know if this approach is obvious.. @peol, please have a look 😄

@peol

peol approved these changes Feb 4, 2019

Copy link
Member

peol left a comment

LGTM, but I don't have an app I can easily reproduce it on so perhaps @sublibra can look at it too

@@ -101,10 +101,10 @@ function useSelections(model, layout, selfRef) {
const onRowClick = async ({ rowData }) => {
if (rowData) {
const rowDataToModify = rowData;
if (rowData[0].qState !== 'S') {
if (rowData[0].qState !== 'S' && rowData[0].qState !== 'XS') {

This comment has been minimized.

@peol

peol Feb 4, 2019

Member

I'm not sure this case is 100% correct, might be a scenario where mapping it to 'S' is wrong, but I cannot test now and edge cases here are fine by me.

@hrigner

This comment has been minimized.

Copy link
Member Author

hrigner commented Feb 6, 2019

So, new color scheme for selected but excluded. Please have a re-look :)

@sublibra

This comment has been minimized.

Copy link
Contributor

sublibra commented Feb 6, 2019

It matches more closely to QlikView and is consistent! I like it!

In the future we might need to investigate the introduction of a third selection mechanism (QlikView has ctrl-click, Qlik Sense green mark, catwalk click outside the component). But this shouldn't be handled in the PR.

@sublibra sublibra self-requested a review Feb 6, 2019

@hrigner hrigner merged commit 68473bd into master Feb 7, 2019

3 of 4 checks passed

coverage/coveralls Coverage decreased (-0.03%) to 5.098%
Details
ci/circleci: build Your tests passed on CircleCI!
Details
cla/verification CLA OK
deploy/netlify Deploy preview ready!
Details

@axelssonHakan axelssonHakan deleted the selected-excluded branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment