This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Adding styling to show differences between selected states #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for catwalk-qlikcore ready! Built with commit 120c0bc |
|
I don't know if this approach is obvious.. @peol, please have a look 😄 |
peol
approved these changes
Feb 4, 2019
src/components/filterbox.jsx
Outdated
| @@ -101,10 +101,10 @@ function useSelections(model, layout, selfRef) { | |||
| const onRowClick = async ({ rowData }) => { | |||
| if (rowData) { | |||
| const rowDataToModify = rowData; | |||
| if (rowData[0].qState !== 'S') { | |||
| if (rowData[0].qState !== 'S' && rowData[0].qState !== 'XS') { | |||
There was a problem hiding this comment.
I'm not sure this case is 100% correct, might be a scenario where mapping it to 'S' is wrong, but I cannot test now and edge cases here are fine by me.
|
So, new color scheme for selected but excluded. Please have a re-look :) |
|
It matches more closely to QlikView and is consistent! I like it! In the future we might need to investigate the introduction of a third selection mechanism (QlikView has ctrl-click, Qlik Sense green mark, catwalk click outside the component). But this shouldn't be handled in the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168