This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Using hamus.js #250
Merged
Using hamus.js #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for catwalk-qlikcore ready! Built with commit 087d0d2 |
peol
approved these changes
May 3, 2019
src/components/selection-field.jsx
Outdated
| const model = useModel(app, createDefinition(field)); | ||
| const layout = useLayout(model); | ||
| const [model, modelError] = useModel(app, createDefinition(field)); | ||
| if (modelError) { |
There was a problem hiding this comment.
Stylewise, I would've gone with a one-liner on these to keep the logic a bit more condensed so it's easier to read if (modelError) throw modelError;
Just an idea: What about having a error-throwing hook for all of these?
Like:
const [model] = useErrorThrow(useModel(app, createDefinition(field));`
|
You mean sth like my last commit @peol? :) |
|
Yes, that looks great 👍 Perhaps the naming could be better though, feel free to rename from my suggestion, it sounds a little weird now that I see it. Essentially what it does is giving you the result (resolved value) from a promise, so maybe |
|
Hm, true. The throw error-thingie is just a nice side effect.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #217