This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
New field and filterbox implementation #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gabbaxx
commented
Oct 25, 2018
gabbaxx
commented
- Virtual scrolling in filterbox with full range data paging
- Key type visible as 1..n, 1..1, n..n labels on the link, and not only color shades
- Sublime color indications for zero and one matching values in a field
- Support for data islands
- Initial support for example values in the hover title
- Right aligned frequency column in filterbox
# Conflicts: # package.json # src/components/filterbox.jsx
|
Deploy preview for catwalk ready! Built with commit 84c0d08 |
hrigner
reviewed
Oct 25, 2018
hrigner
reviewed
Oct 25, 2018
hrigner
reviewed
Oct 25, 2018
hrigner
reviewed
Oct 25, 2018
hrigner
reviewed
Oct 25, 2018
hrigner
reviewed
Oct 25, 2018
peol
approved these changes
Oct 25, 2018
| <div role="Listbox" tabIndex="-1" className="filterbox" style={style} onClick={preventDefaultFn}> | ||
| {search} | ||
| <ul className="items">{items}</ul> | ||
| <div role="Listbox" tabIndex="-1" className="filterbox" onClick={preventDefaultFn}> |
There was a problem hiding this comment.
We're mixing "listbox" and "filterbox" a lot now, can we use one name for it?
Fix for resetting search in filterbox
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.