Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Decrease the number of tasks done in the reload command #73

Closed
sublibra opened this issue Oct 15, 2018 · 0 comments · Fixed by #96
Closed

Decrease the number of tasks done in the reload command #73

sublibra opened this issue Oct 15, 2018 · 0 comments · Fixed by #96
Labels
enhancement New feature or request

Comments

@sublibra
Copy link
Collaborator

Limit the number of tasks done in reload to:

  • reload data (not taking new connection strings in consideration)
  • save the data

Add a --no-save parameter

@sublibra sublibra added the enhancement New feature or request label Oct 15, 2018
FredrikFolkesson pushed a commit that referenced this issue Nov 22, 2018
This implements the design we decided on earlier here (https://github.com/qlik-oss/corectl/blob/command-restructure-design/command-design.md) with some small diffs.

The `get` commands are pure and will only get what is in the app, and not set anything.

Added remove commands so you can not only set objects/measures/dimensions but remove them too.



When set:ing something, measures, for example, the measures are picked up from BOTH the command line and the config file. This is the current behavior and has not been changed but perhaps it should? (But in a different PR then)


Structurally I have made some clean-ups in the code broken out a few methods but the focus has been on implementing the new and cleaner API. And more refactoring of the code could be done in the future.

Bidning flags to viper is now done in the `PersistentPreRun` functions since doing it in the `init` method meant that one flag could only be bound to one command.

I think the easiest way to test this is to clone the branch and build the tool and use the new API and check if it feels nice.

This Closes #95, closes #66, closes #86, closes #72, closes #75, closes #73
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant