chore: add error for incorrect load function (#591)

qlik-oss · Mar 31, 2021 · bb6f647 · bb6f647
1 parent 87a172b
commit bb6f647
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/apis/nucleus/src/sn/__tests__/load.spec.js b/apis/nucleus/src/sn/__tests__/load.spec.js
@@ -13,6 +13,16 @@ describe('load', () => {
     clearFromCache('pie');
   });
 
+  it('should throw when load is not a function', async () => {
+    const loader = { then: {} }; // fake promise
+    try {
+      await load('pie', '1.0.0', halo, loader);
+      expect(0).to.equal(1);
+    } catch (e) {
+      expect(e.message).to.equal(`load of visualization 'pie v1.0.0' is not a fuction, wrap load promise in function`);
+    }
+  });
+
   it('should throw when resolving to a falsy value', async () => {
     const loader = () => false;
     try {

diff --git a/apis/nucleus/src/sn/load.js b/apis/nucleus/src/sn/load.js
@@ -12,6 +12,9 @@ export async function load(name, version, { config }, loader) {
   const key = `${name}__${version}`;
   if (!LOADED[key]) {
     const sKey = `${name}${(version && ` v${version}`) || ''}`;
+    if (loader && typeof loader !== 'function') {
+      throw new Error(`load of visualization '${sKey}' is not a fuction, wrap load promise in function`);
+    }
     const p = (loader || config.load)({
       name,
       version,