Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix search result in rtl mode #1181

Merged
merged 2 commits into from
Mar 23, 2023
Merged

fix: fix search result in rtl mode #1181

merged 2 commits into from
Mar 23, 2023

Conversation

quanho
Copy link
Collaborator

@quanho quanho commented Mar 23, 2023 •
edited
Loading

Motivation

To fix qlik-oss/sn-list-objects#196.

Before:
Screenshot 2023-03-23 at 15 19 29

After:
Screenshot 2023-03-23 at 15 21 37

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@quanho quanho closed this Mar 23, 2023
@quanho quanho reopened this Mar 23, 2023
@quanho quanho merged commit abb33a3 into master Mar 23, 2023
@quanho quanho deleted the hva/sn-filter-pane-196 branch March 23, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veinfors veinfors veinfors approved these changes

@DanielS-Qlik DanielS-Qlik DanielS-Qlik approved these changes

@johanlahti johanlahti Awaiting requested review from johanlahti

@T-Wizard T-Wizard Awaiting requested review from T-Wizard

@PurwaShrivastava PurwaShrivastava Awaiting requested review from PurwaShrivastava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTL search result letter's order looks weird
3 participants
@quanho @veinfors @DanielS-Qlik