-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: listbox properties spec #1228
Conversation
77da6af
to
ad17948
Compare
ad17948
to
1d7a751
Compare
Should we really put this here? Think it will just be more confusing if we mix this into the other Nebula stuff. Could instead reference a different api, either a nebula-list-box or the sn-listbox one. |
Sure, can agree that it could be nice to have it as a separate Api. We have already discussed it a little bit back and forth, but let's have a little talk about it tomorrow and decide what to do. |
If we split it to a different api, I don't know how to reference it in a way that also get the types for the generated typescript definition. @Caele: except that it it something like #1245 you want instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Don't really know how we "solve" typings for TS, but I think this is a safer approach to get us started.
Start of ListboxProperties spec
Motivation
Requirements checklist
yarn spec
When build and tests have passed: