Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose classnames #673

Merged
merged 4 commits into from
Sep 15, 2021
Merged

feat: expose classnames #673

merged 4 commits into from
Sep 15, 2021

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented Sep 10, 2021

Motivation

Adds static classnames to charts:

  • title
  • subtitle
  • footer
  • action buttons

To allow for some basic re-styling of embedded charts through css:
Example:

div.njs-cell {
    background: maroon;
}

p.njs-cell-footer, h6.njs-cell-title, p.njs-cell-sub-title {
    color: white;
}

button.njs-cell-action {
    color: white;
}

This would be a workaround until a proper full UI. theme can be exposed

@Caele Caele marked this pull request as ready for review September 15, 2021 11:43
@Caele Caele merged commit 74fde09 into master Sep 15, 2021
@Caele Caele deleted the tsm/expose-classes branch September 15, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants