Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(spec): test api goverance #756

Closed
wants to merge 47 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
68d62f7
chore: update scriptappy version
veinfors Feb 8, 2022
4bf0f9b
test: teststetetsts
veinfors Feb 8, 2022
5e08e1f
test: tetetete
veinfors Feb 8, 2022
5945660
test: change to qae
veinfors Feb 8, 2022
f2034d0
test: whole json
veinfors Feb 8, 2022
2a3185c
test: commit 2
veinfors Feb 8, 2022
5291757
test: big chunk
veinfors Feb 8, 2022
62b00c4
test: restore engine types
veinfors Feb 8, 2022
5ce76c0
test: change renderstate
veinfors Feb 8, 2022
49ccffd
test: add receiverfunction
veinfors Feb 8, 2022
e2a83fb
test: add ThemeJSON
veinfors Feb 8, 2022
81463e3
test: add VizElementAttributes
veinfors Feb 8, 2022
c9574b6
test: add field target callbacks
veinfors Feb 8, 2022
f3213ef
test: remove description on field target callbacks
streamside Feb 9, 2022
7570352
chore: activate api gov task on forks
streamside Feb 9, 2022
48d7b19
chore: revert api gov filtering
streamside Feb 9, 2022
bf061e9
test: remove generic type on field target callbacks
streamside Feb 9, 2022
f2e0be8
test: capitalize callbacks
streamside Feb 9, 2022
e3578cb
test: remove callbacks
streamside Feb 9, 2022
7b8a162
test: remove removed callback
streamside Feb 9, 2022
135bb27
test: remove params
streamside Feb 9, 2022
12ef68b
test: remove added callback
streamside Feb 9, 2022
61ab231
test: revert to old FieldTarget spec
streamside Feb 9, 2022
863448f
test: add fieldTargetAddedCallback
streamside Feb 9, 2022
5d9d558
test: change to type fieldTargetAddedCallback
streamside Feb 9, 2022
55e6d9a
test: change type to importProperties
streamside Feb 9, 2022
4265bf6
test: change type to EngineAPI.IGenericObjectProperties
streamside Feb 9, 2022
614c3a5
test: remove added prop
streamside Feb 9, 2022
9208323
test: add return type
streamside Feb 9, 2022
ab19a72
test: remove added and removed props
streamside Feb 9, 2022
9959d5a
test: revert props added and removed
streamside Feb 9, 2022
db6b13f
test: change added prop to type defs/importProperties
streamside Feb 9, 2022
8604786
test: change prop added to type string
streamside Feb 9, 2022
dee8adf
test: revert to old added prop
streamside Feb 9, 2022
12dded0
test: remove params on added prop
streamside Feb 9, 2022
46baed0
test: remove generic type on FieldTarget
streamside Feb 9, 2022
84134ca
test: change type on added property to type importProperties
streamside Feb 9, 2022
4c75a52
test: added importProperties as prop, removed added
streamside Feb 9, 2022
074e698
test: keep only importProperties prop on FieldTarget
streamside Feb 9, 2022
f560f79
test: revert props on FieldTarget
streamside Feb 9, 2022
4c0f975
test: remove added prop
streamside Feb 9, 2022
07f17fb
test: added prop added of type string to FieldTarget
streamside Feb 9, 2022
be3aac8
test: change type to function on added prop
streamside Feb 9, 2022
f447a7f
test: change prop load on ThemeInfo to type string
streamside Feb 9, 2022
f413460
test: change type to importProperties on ThemeInfo.load
streamside Feb 9, 2022
94b0950
test: revert ThemeInfo.load
streamside Feb 9, 2022
1728804
test: kind object -> type string
streamside Feb 9, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions apis/nucleus/src/components/listbox/listbox-selections.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,19 @@ export function getElemNumbersFromPages(pages) {
return elemNumbers;
}

/**
* @typedef {object} MinMaxResult
* @property {number} min
* @property {number} max
*/

/**
* Returns the min and max indices of elemNumbersOrdered which contains
* all numbers in elementNbrs.
*
* @param {array(number)} elementNbrs
* @param {array(number)} elemNumbersOrdered
* @returns { min: {number}, max: {number} }
* @param {number[]} elementNbrs
* @param {number[]} elemNumbersOrdered
* @returns {MinMaxResult}
*/
function getMinMax(elementNbrs, elemNumbersOrdered) {
let min = Infinity;
Expand Down
71 changes: 11 additions & 60 deletions apis/stardust/api-spec/spec.json
Original file line number Diff line number Diff line change
Expand Up @@ -1247,13 +1247,7 @@
"entries": {
"info": {
"description": "Object that can hold various meta info about the plugin",
"kind": "object",
"entries": {
"name": {
"description": "The name of the plugin",
"type": "string"
}
}
"type": "string"
},
"fn": {
"description": "The implementation of the plugin. Input and return value is up to the plugin implementation to decide based on its purpose.",
Expand Down Expand Up @@ -1772,52 +1766,7 @@
}
}
},
"fieldTargetAddedCallback": {
"templates": [
{
"name": "T"
}
],
"kind": "function",
"params": [
{
"name": "field",
"type": "T"
},
{
"name": "properties",
"type": "EngineAPI.IGenericObjectProperties"
}
]
},
"fieldTargetRemovedCallback": {
"templates": [
{
"name": "T"
}
],
"kind": "function",
"params": [
{
"name": "field",
"type": "T"
},
{
"name": "properties",
"type": "EngineAPI.IGenericObjectProperties"
},
{
"name": "index",
"type": "number"
}
]
},
"FieldTarget": {
"templates": [
{
"name": "T"
}
],
"kind": "interface",
"entries": {
"min": {
Expand All @@ -1838,19 +1787,21 @@
},
"added": {
"optional": true,
"type": "#/definitions/fieldTargetAddedCallback",
"generics": [
{
"type": "T"
}
]
"kind": "function",
"params": []
},
"removed": {
"optional": true,
"type": "#/definitions/fieldTargetRemovedCallback",
"generics": [
"kind": "function",
"params": [
{
"type": "T"
},
{
"type": "qae.GenericObjectProperties"
},
{
"type": "number"
}
]
}
Expand Down
3 changes: 1 addition & 2 deletions apis/stardust/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@
"@nebula.js/supernova": "^2.3.1",
"@nebula.js/theme": "^2.3.1",
"@nebula.js/ui": "^2.3.1",
"@scriptappy/cli": "0.0.1",
"@scriptappy/from-jsdoc": "0.7.0",
"@scriptappy/cli": "0.1.0",
"@scriptappy/to-dts": "1.0.0-beta.4",
"extend": "3.0.2",
"node-event-emitter": "0.0.1",
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
"rollup-plugin-dependency-flow": "0.3.0",
"rollup-plugin-sass": "1.2.10",
"rollup-plugin-terser": "7.0.2",
"scriptappy-from-jsdoc": "0.7.0",
"yargs": "17.3.0"
},
"resolutions": {
Expand Down
Loading