Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: deprecating after work tests - Part 11 #998

Merged
merged 4 commits into from
Nov 9, 2022
Merged

test: deprecating after work tests - Part 11 #998

merged 4 commits into from
Nov 9, 2022

Conversation

a-m-dev
Copy link
Member

@a-m-dev a-m-dev commented Nov 8, 2022

Motivation

nucleus/src/components/listbox/__tests__ directory done!

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@a-m-dev a-m-dev mentioned this pull request Nov 8, 2022
Closed
11 tasks
@a-m-dev a-m-dev requested a review from Caele November 8, 2022 15:55
@a-m-dev a-m-dev merged commit 7b31465 into qlik-oss:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caele Caele Caele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-m-dev @Caele