Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show a message to upgrade node when needed #999

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

LiKang6688
Copy link
Contributor

@LiKang6688 LiKang6688 commented Nov 8, 2022

Motivation

resolve #996

Head:
Screenshot 2022-11-08 at 15 26 46

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@LiKang6688 LiKang6688 requested a review from a team November 8, 2022 14:29
Copy link
Collaborator

@Caele Caele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@@ -27,7 +27,7 @@ If the proposal includes new designs or bigger changes, please be prepared to di

### Prerequisites

- [Node.js](https://nodejs.org/) 10+ and [yarn](https://yarnpkg.com) 1.9.4 installed
- [Node.js](https://nodejs.org/) 18.10.0+ and [yarn](https://yarnpkg.com) 1+ installed
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in sync with @qlik/sdk to be 18.10.0+

@LiKang6688 LiKang6688 merged commit caa4174 into master Nov 11, 2022
@LiKang6688 LiKang6688 deleted the feat/check-node-version branch November 11, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Show a message to upgrade Node when needed
2 participants