This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
feat: added zoom and pan for viewstate #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haxxmaxx
reviewed
Feb 18, 2020
haxxmaxx
reviewed
Feb 18, 2020
niekvanstaveren
commented
Feb 18, 2020
src/index.js
Outdated
| @@ -48,7 +48,13 @@ export default function supernova(env) { | |||
| const [opts] = useState(options); | |||
| const selectionsAPI = useSelections(); | |||
| const constraints = useConstraints(); | |||
| const [selectionsAndTransform] = useState({ api: selectionsAPI, setState: setSelectionState, linked: false, transform: {} }); | |||
| const [selectionsAndTransform] = useState({ | |||
There was a problem hiding this comment.
Yes we would probably have to rename this one again! Any suggestions are welcome of course
There was a problem hiding this comment.
selectionAndTransformAndConstraints
There was a problem hiding this comment.
Can't think of anything on top of my head. Maybe something to indicate that is persisted and stuff can be update updated without reseting the entire object.
Caele
approved these changes
Feb 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching between edit and analysis mode everything will re-render now. Tried to keep the state but that did not really work for zooming/panning.
We might have another try later, but wanted to get the viewstate in for download/export at least
EDIT: We do keep the zoom pan state between edit and analysis mode now