feat(IM-5878): consider scroll position when taking snapshot #520
Conversation
| rowPartialHeight: 125, | ||
| visibleTopIndex: 5, | ||
| visibleRows: 16, | ||
| page: 0, | ||
| rowsPerPage: 0, |
There was a problem hiding this comment.
Hard coded for testing the scrolled table snapshot.
I think only the rowPartialHeight is considered for snapshot, so I'll remove the rest of properties for this PR. But they will be probably needed later for export improvement.
| useMemo( | ||
| () => createViewService(layout.snapshotData), | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| [layout.snapshotData, pageInfo.page], |
There was a problem hiding this comment.
I'm not sure pageInfo.page should be in the dependencies. It was there before, so I kept it as it is.
There was a problem hiding this comment.
pageInfo.page in deps means that the view service is "reset" or re-created when page changes. Which is what we want since all states in viewService are based on the current page.
Donya-qlik
changed the title
Donya-qlik
changed the title
Donya-qlik
changed the title
| const element = verticalScrollableContainerRef.current; | ||
| if (element) { | ||
| // element.scrollLeft = scrollLeft; | ||
| element.scrollTop = scrollTopPartially; |
There was a problem hiding this comment.
I definitely need to add a similar property for scrolLeft and other conditions if there are more, but maybe we can focus on vertical scroll for this PR
What is the improvement ?:
Pivot table snapshot should consider the scroll position so WYSIWYG as the result.
How it is improved:
The idea is when the snapshot is taken,
snapshotData contentprovides one more propertyrowPartialScrollHeightbefore the table re-renders. The considered property is basically a calculation for finding the hidden part of the table row when the scroll is positioned and add the result to the scrollTop/Left values when the snapshot is used.Before merging this PR, all get-view-state properties will be reset to 0 to ensure they do not affect the current snapshot state. This will remain the case until further calculations are added
The attachment shows how the pv table looks like when the row partial height is applied on the snapshot.
