Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

chore: downgrade node version required #393

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

T-Wizard
Copy link
Collaborator

For use in sense-client that only has node 18.15.0 because of nodejs/node#47563

Comment on lines 27 to 29
"engines": {
"node": ">=v18.16.0"
"node": ">=v18.15.0"
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or should we fully remove required node version?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either that, or tell renovate not to update engines...

@T-Wizard
Copy link
Collaborator Author

T-Wizard commented Apr 25, 2023

As this is, I expect it to only be temporary and that renovate will update it again
[edit]: disabled renovate "engines" updates

@veinfors
Copy link
Collaborator

As this is, I expect it to only be temporary and that renovate will update it again

We could get around that by telling renovate not to update "engines" like this:

"packageRules": [
  {
    "depTypeList": ["engines"],
    "enabled": false
  }
]

As it's done in picasso for instance: https://github.com/qlik-oss/picasso.js/blob/0c9fd35249ae1a911dc77b02b04d99a05c99df43/renovate.json#L7

For use in sense-client that only has node 18.15.0
because of nodejs/node#47563
@T-Wizard T-Wizard merged commit 93e5e4c into main Apr 26, 2023
2 checks passed
@T-Wizard T-Wizard deleted the downgrade-node-required branch April 26, 2023 08:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants