feat: support only output dts #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
是什么场景会使得：仅使用 vite 打包 dts，而用其他工具打包 js 代码？ |
|
这是一个需求vue-core |
|
上面说的 |
qmhc
requested changes
Jul 30, 2023
examples/ts/vite.config.ts
Outdated
| @@ -28,6 +28,7 @@ export default defineConfig({ | |||
| staticImport: true, | |||
| // insertTypesEntry: true, | |||
| rollupTypes: true | |||
| // onlyDts:tru | |||
src/plugin.ts
Outdated
| @@ -680,6 +681,13 @@ export function dtsPlugin(options: PluginOptions = {}): import('vite').Plugin { | |||
| logger.info( | |||
| green(`${logPrefix} Declaration files built in ${timeRecord + Date.now() - startTime}ms.\n`) | |||
| ) | |||
| }, | |||
| generateBundle(_: any, bundle: Record<any, any>) { | |||
src/types.ts
Outdated
| /** | ||
| * Whether to output only dts | ||
| */ | ||
| onlyDts?: boolean, |
There was a problem hiding this comment.
请更名为 declarationOnly，并配上更详细的描述，特别要描述该选项会删除所有 vite 打包的原始产物，同时应添加默认值说明。
除此之外，还需要在两个 README 的选项文档中添加相应的内容。
qmhc
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
过去输出dts同时会输出其他js产物
现在支持仅输出dts文件