-
-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keymap] Updates to personal Drop ALT keymap #13058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads up, the massdrop boards don't officially support eeprom.
Yeah :( I grabbed the updated mdloader from Massdrop/mdloader#49 and modified qmk_firmware\tmk_core\common\arm_atsam\eeprom.c locally to make everything work, but it seems fine (and harmless?) |
I just realized some RGB-related changes were made to the default drop alt keymap, so I incorporated those changes into this PR (and removed a legacy hack I had to address the flickering caps lock key which has now been fixed properly). |
…the default keymap
0f17230
to
671fa1e
Compare
Thank you for your contribution! |
Thanks! |
Description
This PR contains small updates to my personal keymap for the Drop ALT keyboard. Primarily the changes are to enable EEPROM persistence for the RGB mode, to avoid having to reset the RGB pattern every time the board loses power.
It's worth noting that EEPROM is still disabled by default for the Drop ALT, so for this to actually work changes are also needed from #6068 which is unfortunately stuck in limbo.
I'd still like to get these keymap changes into mainline though, as they compile and run fine on their own.
Types of Changes
Checklist