Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keymap] Updates to personal Drop ALT keymap #13058

Merged
merged 3 commits into from
Jul 20, 2021

Conversation

ewersp
Copy link
Contributor

@ewersp ewersp commented May 31, 2021

Description

This PR contains small updates to my personal keymap for the Drop ALT keyboard. Primarily the changes are to enable EEPROM persistence for the RGB mode, to avoid having to reset the RGB pattern every time the board loses power.

It's worth noting that EEPROM is still disabled by default for the Drop ALT, so for this to actually work changes are also needed from #6068 which is unfortunately stuck in limbo.

I'd still like to get these keymap changes into mainline though, as they compile and run fine on their own.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ewersp ewersp changed the title [Keymap] Update keymap to take advantage of EEPROM storage [Keymap] Update personal Drop ALT keymap to take advantage of EEPROM storage May 31, 2021
@ewersp ewersp changed the title [Keymap] Update personal Drop ALT keymap to take advantage of EEPROM storage [Keymap] Updates to personal Drop ALT keymap May 31, 2021
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up, the massdrop boards don't officially support eeprom.

@ewersp
Copy link
Contributor Author

ewersp commented Jun 1, 2021

Just a heads up, the massdrop boards don't officially support eeprom.

Yeah :( I grabbed the updated mdloader from Massdrop/mdloader#49 and modified qmk_firmware\tmk_core\common\arm_atsam\eeprom.c locally to make everything work, but it seems fine (and harmless?)

@ewersp
Copy link
Contributor Author

ewersp commented Jun 1, 2021

I just realized some RGB-related changes were made to the default drop alt keymap, so I incorporated those changes into this PR (and removed a legacy hack I had to address the flickering caps lock key which has now been fixed properly).

@stale
Copy link

stale bot commented Jul 16, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@drashna
Copy link
Member

drashna commented Jul 20, 2021

Thanks!

@drashna drashna merged commit 3591312 into qmk:master Jul 20, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants