Update the nix-shell to work with qmk master. #14217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The qmk build system now expects a newer version of the qmk binary, so we update the python dependencies of the nix-shell to use `qmk = "^1"`. We also remove the dotty-dict dependency, since qmk already depends on it.
|
With #13316 now merged, does this still add value? If so, there are merge conflicts that should be resolved. |
|
#13316 seems to work for me, so I'll close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The qmk build system now expects a newer version of the qmk binary, so
we update the python dependencies of the nix-shell to use
qmk = "^1".We also remove the dotty-dict dependency, since qmk already depends on
it.