Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS Mission Control and Launchpad keys #14645

Conversation

gtg465x
Copy link

@gtg465x gtg465x commented Sep 29, 2021

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@gtg465x
Copy link
Author

gtg465x commented Sep 29, 2021

The Fn keys on Apple keyboards provide media functions by default. All media functions provided by Apple keyboards are supported by QMK except for Mission Control and Launchpad, which are usually mapped to the F3 and F4 keys respectively. Apple has added codes for these functions to the official HID spec, so it would be nice for macOS users to not have to write custom user code to get their keyboard to function as expected. I updated my personal user keymap for my keyboard as an example to show what was required before vs with this change.

@fauxpark
Copy link
Member

Please see my first comment on the issue you linked. Also, this PR will need to target develop.

@gtg465x
Copy link
Author

gtg465x commented Sep 29, 2021

Please see my first comment on the issue you linked. Also, this PR will need to target develop.

Shoot, not sure how I missed that. Should I just close the PR then? What's the blocker on "we are waiting to be able to remove the KC_FN* keycodes"? I'll do it. What needs to be done exactly? It seems people have been submitting PRs like this for years now... let's do something about it or it will never get fixed and people will keep on making these requests and PRs.

@gtg465x gtg465x changed the base branch from master to develop September 29, 2021 18:55
@fauxpark
Copy link
Member

It's been on my list, and I've been chipping away at it as and when I can. The removal of the KC_FN* keycodes itself will have to go through develop, as although that whole system is deprecated it is still technically a breaking change.

@RobSjaras
Copy link

@gtg465x Is the code on this PR actual working code? I'm currently looking into getting those 2 keys to work as expected on my Keychron Q1. Thanks.

@gtg465x
Copy link
Author

gtg465x commented Nov 10, 2021

@RobSjaras Yeah, it’s working, but it would be easier to just build from my custom Q1 keymap that’s already in master.

@RobSjaras
Copy link

@gtg465x Yeah I noticed a few minutes after my comment! And then I saw someone had been building on top of that, which I then built on top of. I needed to mirror Mac behavior as much as possible, so I've added caps lock with tap-protection, right ctrl->right alt, and fn+backspace=delete. But yeah, thanks for your work, it works wonders!

@mmshivesh
Copy link

@RobSjaras Im curious on how you implemented Caps Lock with tap protection. You have any pointers?

@RobSjaras
Copy link

@RobSjaras Im curious on how you implemented Caps Lock with tap protection. You have any pointers?

Sorry for the very late reply, December was very hectic for me... Is this still something you're looking to get help for?

@chrismanderson
Copy link

@RobSjaras Im curious on how you implemented Caps Lock with tap protection. You have any pointers?

Sorry for the very late reply, December was very hectic for me... Is this still something you're looking to get help for?

I'd love to see the the caps lock/fn backspace for sure if you have a fork or some such uploaded!

@RobSjaras
Copy link

RobSjaras commented Feb 1, 2022

@RobSjaras Im curious on how you implemented Caps Lock with tap protection. You have any pointers?

Sorry for the very late reply, December was very hectic for me... Is this still something you're looking to get help for?

I'd love to see the the caps lock/fn backspace for sure if you have a fork or some such uploaded!

So I finally got around to doing it! Have yet to document anything, but my goal was changing one of the previous setups and make the keyboard act more like a true macOS keyboard.

RobSjaras@4071b33

@mmshivesh @chrismanderson

@stale
Copy link

stale bot commented Apr 16, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase - the FN keys are now gone and there is space to add these keycodes contiguously.

@stale stale bot removed the awaiting changes label Apr 17, 2022
@drashna drashna requested a review from a team April 18, 2022 09:12
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 13, 2022
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core documentation keymap stale Issues or pull requests that have become inactive without resolution. translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants