cantor: fix LT(layer, kc) do not work after waking up PC #16406 #20205
Conversation
Refactor of the orignal Philong's workaround. Instead of a user function in the keymap this commit applies the workarund at the keyboard level to make it available to every cantor user. Co-authored-by: Philong <philong@users.noreply.github.com>
| // Workaround for https://github.com/qmk/qmk_firmware/issues/16406 | ||
| __attribute__ ((weak)) | ||
| void suspend_wakeup_init_kb(void) { | ||
| NVIC_SystemReset(); |
There was a problem hiding this comment.
This isn't a fix. That's a hard reset...
You'd be better off just adding QK_BOOT to your keymap.
There was a problem hiding this comment.
Thank you @drashna for the review. Could you expand a bit more on how adding a QK_BOOT is better than this?
As I wrote in the description this is not a fix but a workaround.
With a 36 keys layout there is no space for a QK_BOOT on the first layer, and the bug itself, that blocks the dual function keys will make it impossible to have activate it from another layer.
I already shared in the PR description that my knowledge of the QMK internals is very poor, so I think I may be missing something here. Could you please explain me why an hard reset is so problematic with a simple design like the cantor that has no fancy features (no RGB, no diodes, no speakers, no rotary encoders).
Thank you
There was a problem hiding this comment.
Force rebooting when it wakes is no t the right way to handle this, at all. This may actually cause issues for other users that are not experiencing the issue.
#19780 is aimed at fixing the issue correctly, in core.
In the meanwhile, NO_SUSPEND_POWER_DOWN = yes in your rules.mk would likely solve this issue, as would #define USB_SUSPEND_WAKEUP_DELAY 200 in your config.h.
There was a problem hiding this comment.
Thanks for explaining, I'll close this PR
Reset the cantor after a wakeup event to unblock
LT(layer, kc)keys.Description
Refactor of the original @philong workaround #16406 (comment).
Instead of a user function in the keymap this commit applies the workarund at the keyboard level to make it available to every cantor user.
As the author said in the issue,
I don't have the knowledge to make a proper fix for the BlackPill board, but this small workaround is working for me on cantor remix (36 keys version) and I think is worth make it more available to the users.
This could be reverted as soon as someone have a proper fix for the underlaying problem.
Types of Changes
Issues Fixed or Closed by This PR
Checklist