Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonix SLED1734x RGB matrix support #21081

Closed
wants to merge 80 commits into from
Closed

Sonix SLED1734x RGB matrix support #21081

wants to merge 80 commits into from

Conversation

dexter93
Copy link
Contributor

@dexter93 dexter93 commented May 29, 2023 •
edited
Loading

Description

Basic support for SLED1734X LED driver.

This is the SLED1734X (SSOP 28pins): I2C variant of the generic SLED1734 chip.

Default configuration is for RGB matrix type 3 ( max 256 LEDS on 2 split frames)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

dexter93 and others added 30 commits October 15, 2022 19:49
@dexter93
introduce flexibility in matrix scan timing
d241419 
`CUSTOM_MATRIX = shared`

This custom matrix alternative allows for precise timing control on the matrix scan, as needed with shared matrix keyboards.
The user has to bring his own matrix_scan function, but not rewrite the whole matrix code.
@dexter93
expose some more matrix functions
dc9b0a4
@dexter93
add shared matrix sn32f24xb driver
84ec98d 
This is a shared matrix driver. It handles both RGB pwm and key matrix scan.
@dexter93
core: allow locking the matrix state
4d7992f 
introducing flexibility on matrix tasks timing. matrix state can now be locked when we don't need a matrix scan
@dexter93
address the PR comments
942012e
@dexter93
fix core matrix linting
dc9afdd
@dexter93
some formatting
f5ed0ce
@dexter93 @sigprof
Update drivers/led/sn32/rgb_matrix_sn32f24xb.c
398219a 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@dexter93 @sigprof
Update drivers/led/sn32/rgb_matrix_sn32f24xb.c
fe8d667 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@dexter93 @sigprof
Update drivers/led/sn32/rgb_matrix_sn32f24xb.c
4eb9b0d 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@dexter93 @sigprof
Update drivers/led/sn32/rgb_matrix_sn32f24xb.c
a437bcf 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@dexter93
rename to matrix_available
81ae361 
swap the logic, introduce prototypes & readme
@dexter93
use matrix_available
0060888
@dexter93 @sigprof
Update quantum/keyboard.c
adbe4e2 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@dexter93 @sigprof
Update quantum/keyboard.c
63096d7 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@dexter93 @sigprof
Update quantum/keyboard.c
8945622 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@dexter93
fix ROW2COL build
21c44ad
@dexter93
Revert "expose some more matrix functions"
cb9c80e 
This reverts commit dc9b0a4.
@dexter93
Revert "introduce flexibility in matrix scan timing"
70d25bf 
This reverts commit d241419.
@dexter93
remove redundant else
25f91c7
@dexter93
fix lint
a8f6565
@dexter93
core: move matrix scan in matrix_common
e192a58 
stock matrix_scan function is a glorified custom function by default.
Time to actually be one
@dexter93
core: move matrix scan in matrix_common
e60208f 
stock matrix_scan function is a glorified custom function by default.
Time to actually be one
@dexter93
core: move matrix init in matrix_common
c1e8915
@dexter93
matrix_common: follow the api
ed52a0d
@dexter93
remove the noscan checks
f3983e1
@dexter93
core: make the default scan routine weak
faceff1 
this allows user override without compromising the rest of matrix.c
@dexter93
core: make the default init routine weak
6cc6725 
this allows user override without compromising the rest of matrix.c
@dexter93
expose some more matrix functions
2f56063
@dexter93
more linting
8863a00
dexter93 and others added 20 commits June 20, 2023 11:12
@dexter93
Revert "Partially revert the bool handling "
aaebf3c 
This reverts commit d4b3b50.
@dexter93
Revert "Merge remote-tracking branch 'Dexter93/matrix_lock' into sn32…
c27986a 
…_develop"

This reverts commit 406af93, reversing
changes made to cdea8af.
@dexter93
Revert "Merge remote-tracking branch 'Dexter93/matrix_common' into sn…
294bf4a 
…32_develop"

This reverts commit cdea8af, reversing
changes made to dedc54a.
@dexter93
Merge remote-tracking branch 'qmk/develop' into sn32_staging
19a9154
@dexter93
sn32: shared matrix: update the matrix availability flag
ac93397
@dexter93
sn32f2xb shared matrix: speed up
1464bce 
declare the matrix scanned after each col pass
@dexter93
add onekey for all sn32 targets
4e09c12
@dexter93
core: sn32: add support for shared matrix
fea6722 
non-standard approach. This hijacks the matrix functions but leaves
the matrix scan out.
@dexter93
chibios-contrib: switch to our fork
324e541
@dexter93
inherit latest SonixQMK/Chibios-Contrib
5d2bd0e
@elpekenin
add ozone tactical (SonixQMK#321)
b1647a6 
* add ozone tactical

* Remove trash

* Update copyright header
@dexter93
Add designedbyGG Berserker (SonixQMK#335)
9c71422 
BSK-01 support
@dexter93
core: formatting updates
b4f9412
@dexter93
Add support for Designed by GG Ironclad (SonixQMK#315)
a80e21d 
* Add designedbyGG Ironclad

support ICL-01 v1 and v2

* linter gone wild here
let's do something more.. readable

* bump debounce time for ironlad to 10ms
@dexter93
Revert "inherit latest SonixQMK/Chibios-Contrib"
a19afe9 
This reverts commit 5d2bd0e.
@dexter93
Merge remote-tracking branch 'qmk/develop' into sn32_develop
775eaa8
@dexter93
inherit latest SonixQMK/Chibios-Contrib
29374fc
@dexter93
sn32f2xb shared matrix: fix compilation
e5bb7ba 
quantum.h inclusion got removed with qmk#21507
add the relevant headers to fix build
@dexter93
sled1734x: Optimisation - Add RGB LED colour set check in drivers
f7c3d1d
@dexter93
Merge branch 'sn32_develop' into sonix_sled1734x
57490bd
@github-actions github-actions bot added keyboard keymap python cli qmk cli command via Adds via keymap and/or updates keyboard for via support dependencies labels Jul 21, 2023
@dexter93 dexter93 mentioned this pull request Jul 21, 2023
Merged
14 tasks
@dexter93
sled1734x: speed up the transfers
c3f5ef9 
we can afford to do less and bigger data transfers. Performance metrics
show it's faster than more transfers with less payload
@dexter93
sled1734x: init: use the shutdown functions
d3525be
@dexter93 dexter93 closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cli qmk cli command core dependencies documentation keyboard keymap python via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dexter93 @lokher @Jpe230 @tbowmo @bausensi @iglooom @elpekenin