Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fix_submodules.sh #8

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Fix fix_submodules.sh #8

merged 1 commit into from
Dec 2, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Dec 2, 2022

Description

Didn't actually respect the branch config and just fell back to master for all submodules. Since qmk_metrics_aggregator apparently uses main as the default branch, this broke.

@fauxpark fauxpark added the bug Something isn't working label Dec 2, 2022
@fauxpark fauxpark requested a review from a team December 2, 2022 12:43
@tzarc tzarc merged commit c61b2d5 into master Dec 2, 2022
@tzarc tzarc deleted the fix-fix-submodules branch December 2, 2022 12:53
@fauxpark fauxpark mentioned this pull request Dec 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @tzarc