This repository was archived by the owner on Dec 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
New Examples #66
Merged
Merged
New Examples #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modifications so that tensorflow is no longer a requirement
Made a test that checks that the save/load functions in MRMP work in both cases when the model is saved on the same or different computers
…t_params/set_params functions
Merging changes from upstream
Remade existing QML examples in a notebook
Finished adding Aglaia examples into the documentation
Modified aglaia so that "representation" is used instead of "descriptor"
Very nice addition!! I'll check how the ipynbs will be rendered on github-pages before we merge. My worry is that it'll break the qmlcode.org manual. But looks like it will simply rendered as HTML, if not we might have to change the sphinx makescript or something. |
I have followed what they do in this repository: https://github.com/spatialaudio/nbsphinx So hopefully it should be fine! |
Modified travis.yml to get pandoc
actually removed pip install
andersx
approved these changes
Jul 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the existing QML examples into a notebook and added aglaia examples. The aglaia examples can be run in the notebook. We might have to modify the existing QML examples at some point so that they can be run too.
Also made modifications to the aglaia module so that it is consistent with QML in using the word "representation" instead of "descriptor".