Skip to content
This repository was archived by the owner on Dec 8, 2024. It is now read-only.

Conversation

SilviaAmAm
Copy link
Collaborator

Moved the existing QML examples into a notebook and added aglaia examples. The aglaia examples can be run in the notebook. We might have to modify the existing QML examples at some point so that they can be run too.

Also made modifications to the aglaia module so that it is consistent with QML in using the word "representation" instead of "descriptor".

modifications so that tensorflow is no longer a requirement
Made a test that checks that the save/load functions in MRMP work in both cases when the model is saved on the same or different computers
Remade existing QML examples in a notebook
Finished adding Aglaia examples into the documentation
Modified aglaia so that "representation" is used instead of "descriptor"
@andersx
Copy link
Member

andersx commented Jul 26, 2018

Very nice addition!!

I'll check how the ipynbs will be rendered on github-pages before we merge. My worry is that it'll break the qmlcode.org manual. But looks like it will simply rendered as HTML, if not we might have to change the sphinx makescript or something.

@SilviaAmAm
Copy link
Collaborator Author

I have followed what they do in this repository: https://github.com/spatialaudio/nbsphinx
They did pretty much all the documentation using notebooks and sphinx and it seems to render fine on their readthedocs: http://nbsphinx.readthedocs.io/en/0.3.3/index.html

So hopefully it should be fine!

Copy link
Member

@andersx andersx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andersx andersx merged commit 17a8076 into qmlcode:develop Jul 28, 2018
zaspel pushed a commit to zaspel/qml that referenced this pull request Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants