Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module line #2

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Fix module line #2

merged 1 commit into from
Mar 20, 2019

Conversation

matt0xFF
Copy link
Contributor

Thanks for open sourcing this! I tried using it as a dependency (using modules) but got the following error:

go get github.com/qmuntal/gltf
go: finding github.com/qmuntal/gltf v0.7.0
go: github.com/qmuntal/gltf@v0.7.0: parsing go.mod: unexpected module path "gltf"
go: error loading module requirements

I'm not an expert on modules, but after looking in to it it looks like the module path is specified incorrectly (the examples at github.com/golang/go/wiki/Modules use the whole path including github). I also tested the fix by updating the path on my fork (to my fork URL) and it fixed the issue.

In order for go get to see it it will need a new release with a version bump too.

Module line needs full path in order for library to work as a dependency
@qmuntal
Copy link
Owner

qmuntal commented Mar 20, 2019

Many thanks! The other day I was also experimenting this issue but I though it had something to do with my local modules config.
I've checked other popular modules and I confirmed that the full uri is necessary in the module file, so I'll release a new version with this fix

@qmuntal qmuntal merged commit 0910383 into qmuntal:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants