Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax SetTriggerParameters check to allow all Go allowed casts #46

Merged
merged 1 commit into from
May 17, 2022
Merged

Relax SetTriggerParameters check to allow all Go allowed casts #46

merged 1 commit into from
May 17, 2022

Conversation

qmuntal
Copy link
Owner

@qmuntal qmuntal commented May 16, 2022 •
edited
Loading

This PR updates SetTriggerParameters so it uses reflect.ConvertibleTo instead of plain type equality.

Closes #45

@qmuntal qmuntal merged commit 491b438 into master May 17, 2022
@qmuntal qmuntal deleted the triggerparams branch May 17, 2022 20:00
@qmuntal qmuntal mentioned this pull request May 17, 2022
Closed
@delwaterman
Copy link

Sweet! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SetTriggerParameters enhancment: validate interfaces
2 participants
@qmuntal @delwaterman