Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly fix #28? #29

Closed
wants to merge 1 commit into from
Closed

Possibly fix #28? #29

wants to merge 1 commit into from

Conversation

edmcman
Copy link

@edmcman edmcman commented Feb 10, 2016

I haven't exhaustively tested, but it fixes the particular regex I was experiencing wrong results for, and a couple others I tried at random.

@qntm
Copy link
Owner

qntm commented Feb 10, 2016

Going to have to reject this pull request, sorry! Although this fixes the specific case you mentioned, it introduces a few other test case failures, starting with test_star_advanced in fsm_test.py. You can run the whole suite using python -m pytest in the base directory of the project.

Also, if you are supplying a bug fix, please also add a test case which demonstrates the bug, like this:

def test_bug_28():
    # Defect in lego.to_fsm()
    assert not parse("(ab*)*").to_fsm().accepts("bb")

@qntm qntm closed this Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants